Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added type=button to buttons #2471

Closed
wants to merge 1 commit into from
Closed

Conversation

mmcc
Copy link
Member

@mmcc mmcc commented Aug 13, 2015

Fixes #2470

@tjenkinson
Copy link
Contributor

Don't you mean type=button?

On 13 Aug 2015, at 08:34, Matthew McClure notifications@github.com wrote:

Fixes #2470

You can view, comment on, or merge this pull request online at:

#2471

Commit Summary

added type=submit to button. fixes #2470
File Changes

M src/js/button.js (5)
Patch Links:

https://github.com/videojs/video.js/pull/2471.patch
https://github.com/videojs/video.js/pull/2471.diff

Reply to this email directly or view it on GitHub.

@pam
Copy link

pam commented Aug 13, 2015

Tests failed. Automated cross-browser testing via Sauce Labs and Travis CI shows that the JavaScript changes in this pull request are: BUSTED

Commit: b40e8781f1f87976ed435744c8cd7dc7127ec3e2
Build details: https://travis-ci.org/pam/video.js/builds/75394605

(Please note that this is a fully automated comment.)

@mmcc
Copy link
Member Author

mmcc commented Aug 13, 2015

Ha yes, yes I did mean that. Code is right, title is not. 

Edit: Updated. Thanks!


Sent from mobile

On Thu, Aug 13, 2015 at 12:41 AM, Project Automation Manager
notifications@github.com wrote:

Tests failed. Automated cross-browser testing via Sauce Labs and Travis CI shows that the JavaScript changes in this pull request are: BUSTED
Commit: b40e8781f1f87976ed435744c8cd7dc7127ec3e2
Build details: https://travis-ci.org/pam/video.js/builds/75394605
(Please note that this is a fully automated comment.)


Reply to this email directly or view it on GitHub:
#2471 (comment)

@mmcc mmcc changed the title Added submit type to button Added type=button to buttons Aug 13, 2015
@heff
Copy link
Member

heff commented Aug 13, 2015

lgtm

@mmcc mmcc force-pushed the add-type-submit branch from b40e878 to efc9f70 Compare August 13, 2015 20:42
@mmcc mmcc closed this in 20b2a78 Aug 13, 2015
@pam
Copy link

pam commented Aug 13, 2015

Tests failed. Automated cross-browser testing via Sauce Labs and Travis CI shows that the JavaScript changes in this pull request are: BUSTED

Commit: efc9f70
Build details: https://travis-ci.org/pam/video.js/builds/75506086

(Please note that this is a fully automated comment.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants