use setAttribute when adding type property. Fixes #2480 #2487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -43,7 +43,7 @@ export function createEl(tagName='div', properties={}){ | |||
| // add the attribute "role". My guess is because it's not a valid attribute in some namespaces, although | |||
| // browsers handle the attribute just fine. The W3C allows for aria- * attributes to be used in pre-HTML5 docs. | |||
| // http://www.w3.org/TR/wai-aria-primer/#ariahtml. Using setAttribute gets around this problem. | |||
| if (propName.indexOf('aria-') !== -1 || propName === 'role') { | |||
| if (propName.indexOf('aria-') !== -1 || propName === 'role' || propName === 'type') { | |||
There was a problem hiding this comment.
Fine for now, but if we get any more properties we'd want to case, we should switch to something like:
let properties = {
'role': 1,
'type': 1,
'foo': 1,
'bar'
};
if (propName in properties) {
el.setAttribute(propName, val);
}
|
LGTM |
|
Tests failed. Automated cross-browser testing via Sauce Labs and Travis CI shows that the JavaScript changes in this pull request are: BUSTED Commit: bb5c97a (Please note that this is a fully automated comment.) |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.