Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix console log errors in tests #2513

Closed
wants to merge 0 commits into from
Closed

Conversation

heff
Copy link
Member

@heff heff commented Aug 25, 2015

Even though tests pass we still have a bunch of errors in the test logs from xhr events and browsers trying to load fake images/tracks. This fixes most of them.

See the individual commits.

  • Fixed a console error in dom tests from loading a track source
  • Switched to non-fetching poster urls in tests to prevent errors
  • Stubbed XHR for TextTrack tests to prevent log errors

Still seeing two errors in IE10 that I need to find and clean up.

@gkatsev
Copy link
Member

gkatsev commented Aug 25, 2015

Cool. LGTM

@heff
Copy link
Member Author

heff commented Aug 26, 2015

@gkatsev, FYI, there's some async happening somewhere in tracks that prevents stubbing XHR from working, at least in this test: https://github.com/videojs/video.js/blob/master/test/unit/tracks/tracks.test.js#L119
XHR isn't called until the test is already over. Disposing the player fixed the console errors though.

@heff heff closed this Aug 31, 2015
@heff heff deleted the fix-log-errors branch August 31, 2015 23:40
heff added a commit that referenced this pull request Sep 1, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants