Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seek to the beginning on replay #2527

Closed
wants to merge 1 commit into from

Conversation

dmlap
Copy link
Member

@dmlap dmlap commented Aug 31, 2015

The video.js SWF no longer seeks back to the beginning automatically. Instead, check whether the video has ended on play and seek back to the beginning if necessary.

The video.js SWF no longer seeks back to the beginning automatically. Instead, check whether the video has ended on play and seek back to the beginning if necessary.
@dmlap
Copy link
Member Author

dmlap commented Aug 31, 2015

This is the stable-branch version of #2519

@bc-bbay
Copy link
Contributor

bc-bbay commented Aug 31, 2015

LGTM

@pam
Copy link

pam commented Aug 31, 2015

Tests failed. Automated cross-browser testing via Sauce Labs and Travis CI shows that the JavaScript changes in this pull request are: BUSTED

Commit: 3869eec
Build details: https://travis-ci.org/pam/video.js/builds/78087584

(Please note that this is a fully automated comment.)

@dmlap
Copy link
Member Author

dmlap commented Aug 31, 2015

Pam issue is an IE timeout.

@heff
Copy link
Member

heff commented Aug 31, 2015

LGTM

@dmlap
Copy link
Member Author

dmlap commented Aug 31, 2015

Seeking on end and replaying look good on IE8.

@dmlap dmlap closed this in 90c6890 Aug 31, 2015
@dmlap dmlap deleted the replay-after-ended branch August 31, 2015 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants