Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add component to specific index #2540

Closed
wants to merge 18 commits into from
Closed

add component to specific index #2540

wants to merge 18 commits into from

Commits on Sep 1, 2015

  1. add component to specific index 

    and tests
    @erikyuzwa
    erikyuzwa committed Sep 1, 2015
    Configuration menu
    Copy the full SHA
    80d8f26 View commit details
    Browse the repository at this point in the history

Commits on Sep 2, 2015

  1. Minor changes to #2540

    @heff
    heff committed Sep 2, 2015
    Configuration menu
    Copy the full SHA
    ba0065a View commit details
    Browse the repository at this point in the history

  2. Merge pull request #1 from heff/review-erikyuzwa-feature/add-child-wi… 

    …th-index

Minor changes to #2540
    @erikyuzwa
    erikyuzwa committed Sep 2, 2015
    Configuration menu
    Copy the full SHA
    19cad93 View commit details
    Browse the repository at this point in the history

  3. fixed addChild tests

    @erikyuzwa
    erikyuzwa committed Sep 2, 2015
    Configuration menu
    Copy the full SHA
    0527665 View commit details
    Browse the repository at this point in the history

Commits on Sep 3, 2015

  1. updated failing test with proper index 

    but is it 'right'?
    @erikyuzwa
    erikyuzwa committed Sep 3, 2015
    Configuration menu
    Copy the full SHA
    d763d0e View commit details
    Browse the repository at this point in the history

Commits on Sep 4, 2015

  1. making use of component.addChild 

    using the updated addChild to add our vjs-tech into our DOM children array
    @erikyuzwa
    erikyuzwa committed Sep 4, 2015
    Configuration menu
    Copy the full SHA
    3b0ba5f View commit details
    Browse the repository at this point in the history

  2. restored original media controller test

    @erikyuzwa
    erikyuzwa committed Sep 4, 2015
    Configuration menu
    Copy the full SHA
    0f02202 View commit details
    Browse the repository at this point in the history

Commits on Nov 10, 2015

  1. rewrote child node insertion into dom

    @erikyuzwa
    erikyuzwa committed Nov 10, 2015
    Configuration menu
    Copy the full SHA
    5f02d1f View commit details
    Browse the repository at this point in the history

Commits on Jan 12, 2016

  1. Merge branch 'master' into feature/add-child-with-index 

    Conflicts:
	test/unit/component.test.js
    @erikyuzwa
    erikyuzwa committed Jan 12, 2016
    Configuration menu
    Copy the full SHA
    4e91e67 View commit details
    Browse the repository at this point in the history

  2. updated for webstorm ide

    @erikyuzwa
    erikyuzwa committed Jan 12, 2016
    Configuration menu
    Copy the full SHA
    c5442c8 View commit details
    Browse the repository at this point in the history

Commits on Jan 16, 2016

  1. fixed commented test

    @erikyuzwa
    erikyuzwa committed Jan 16, 2016
    Configuration menu
    Copy the full SHA
    d25a874 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into feature/add-child-with-index

    @erikyuzwa
    erikyuzwa committed Jan 16, 2016
    Configuration menu
    Copy the full SHA
    579215c View commit details
    Browse the repository at this point in the history

Commits on Feb 3, 2016

  1. modified vars to lets

    @erikyuzwa
    erikyuzwa committed Feb 3, 2016
    Configuration menu
    Copy the full SHA
    04fef83 View commit details
    Browse the repository at this point in the history

  2. undo the DOM el function append

    @erikyuzwa
    erikyuzwa committed Feb 3, 2016
    Configuration menu
    Copy the full SHA
    6efa25e View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into feature/add-child-with-index

    @erikyuzwa
    erikyuzwa committed Feb 3, 2016
    Configuration menu
    Copy the full SHA
    ccac3c5 View commit details
    Browse the repository at this point in the history

  4. Revert "undo the DOM el function append" 

    This reverts commit 6efa25e.
    @erikyuzwa
    erikyuzwa committed Feb 3, 2016
    Configuration menu
    Copy the full SHA
    266097a View commit details
    Browse the repository at this point in the history

  5. updated comments to help clarify dom insertion

    @erikyuzwa
    erikyuzwa committed Feb 3, 2016
    Configuration menu
    Copy the full SHA
    cb49200 View commit details
    Browse the repository at this point in the history

  6. reworked dom insertion to allow proper children

    @erikyuzwa
    erikyuzwa committed Feb 3, 2016
    Configuration menu
    Copy the full SHA
    7b7ca3d View commit details
    Browse the repository at this point in the history