Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed the loadedalldata event #2591

Merged
merged 1 commit into from
Sep 15, 2015
Merged

Removed the loadedalldata event #2591

merged 1 commit into from
Sep 15, 2015

Conversation

heff
Copy link
Member

@heff heff commented Sep 15, 2015

Want to get this out before 5.0. Reasoning from #1676.

I think we need to deprecate the loadedalldata event for 5.0. It's a made up event (not from the video element) that has less use these days for a few reasons:

  • For most cases, you should use the canplaythrough event instead of loadedalldata.
  • Browsers manage their buffer more carefully now, they don't just load the whole video at once
  • It doesn't apply to live events

@heff heff added this to the v5.0.0 milestone Sep 15, 2015
@gkatsev
Copy link
Member

gkatsev commented Sep 15, 2015

Should we deprecate the other vjs-only events as well? Like firstplay?

@heff
Copy link
Member Author

heff commented Sep 15, 2015

I think I tried that once and got push back because it's actually useful. Don't we use it in ads or somewhere externally?

@mmcc
Copy link
Member

mmcc commented Sep 15, 2015

lgtm

@heff heff merged commit 4cb7687 into videojs:master Sep 15, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants