Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed argument names in API docs #2714

Closed
wants to merge 3 commits into from
Closed

Conversation

Soviut
Copy link
Contributor

@Soviut Soviut commented Oct 19, 2015

Some jsdoc arguments were missing names.

Fixes #2711

@pam
Copy link

pam commented Oct 19, 2015

Tests failed. Automated cross-browser testing via Sauce Labs and Travis CI shows that the JavaScript changes in this pull request are: BUSTED

Commit: a982c1b
Build details: https://travis-ci.org/pam/video.js/builds/86230232

(Please note that this is a fully automated comment.)

@Soviut
Copy link
Contributor Author

Soviut commented Oct 19, 2015

Doh, I shouldn't have put spaces before the argument names to align them. I've updated the PR.

@pam
Copy link

pam commented Oct 19, 2015

Tests failed. Automated cross-browser testing via Sauce Labs and Travis CI shows that the JavaScript changes in this pull request are: BUSTED

Commit: b64ddf8
Build details: https://travis-ci.org/pam/video.js/builds/86235590

(Please note that this is a fully automated comment.)

@gkatsev gkatsev mentioned this pull request Oct 26, 2015
18 tasks
@gkatsev
Copy link
Member

gkatsev commented Oct 28, 2015

LGTM. Thanks.

@gkatsev gkatsev closed this in 871dac9 Oct 28, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants