Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unhelpful isCrossOrigin test. #2715

Closed
wants to merge 4 commits into from
Closed

Remove unhelpful isCrossOrigin test. #2715

wants to merge 4 commits into from

Commits on Oct 19, 2015

  1. Remove unhelpful isCrossOrigin test. 

    This test was checking that an "https:" page could load
protocol-relative urls as non-cross origin. However, IE and chrome
handled the parsing of the urls differently. In IE, the url was parsed
to have a protocol of ':' which we chould then backfill to be 'https:'.
But chrome parsed it to have a protocol of 'http:' because our test page
was loaded over http. Having this test is causing more issues than is
worth having it.
    @gkatsev
    gkatsev committed Oct 19, 2015
    Configuration menu
    Copy the full SHA
    af4d3ad View commit details
    Browse the repository at this point in the history

  2. Add another assertion

    @gkatsev
    gkatsev committed Oct 19, 2015
    Configuration menu
    Copy the full SHA
    f4e5675 View commit details
    Browse the repository at this point in the history

  3. re-arrange lets

    @gkatsev
    gkatsev committed Oct 19, 2015
    Configuration menu
    Copy the full SHA
    eb32719 View commit details
    Browse the repository at this point in the history

  4. Revert "Add another assertion" 

    This reverts commit f4e5675.
    @gkatsev
    gkatsev committed Oct 19, 2015
    Configuration menu
    Copy the full SHA
    ca5d28a View commit details
    Browse the repository at this point in the history