Add browserify:dist Target #2741
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| transform: [ | ||
| ['browserify-versionify', { | ||
| placeholder: '../node_modules/vtt.js/dist/vtt.js', | ||
| version: 'https://raw.githubusercontent.com/gkatsev/vtt.js/vjs-v0.12.1/dist/vtt.min.js' |
There was a problem hiding this comment.
Actually, we can't link from githubusercontent. This URL should work, though: https://cdn.rawgit.com/gkatsev/vtt.js/vjs-v0.12.1/dist/vtt.min.js
|
Other than the URL change, LGTM. |
| * @param {Mixed} sourceValue | ||
| * @return {Object} | ||
| */ | ||
| function browserifyGruntCustomizer(objectValue, sourceValue) { |
There was a problem hiding this comment.
does this assume default behavior when returning undefined?
There was a problem hiding this comment.
Yeah, that's how the _.merge customizer argument works.
This was referenced Oct 26, 2015
|
@gkatsev URL fixed. |
This adds functions for generating browserify configs to avoid any copy/pasting. The dist target specifically replaces the node_modules version of vtt.js with a raw GitHub URL to address multiple reports of 404ing requests for vtt.js.
misteroneill
force-pushed
the
browserify-dist
branch
from
3b5ef28 to
28f8239
Compare
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds functions for generating browserify configs to avoid any copy/pasting.
The
browserify:disttarget specifically replaces thenode_modulesversion ofvtt.jswith a raw GitHub URL to address multiple reports of 404ing requests forvtt.js. Thenode_modulesversion is maintained for the normalbrowserify:buildtarget (i.e. for local development).This builds on some of the work introduced in #2426