Expose DOM Helpers #2754
Closed
Expose DOM Helpers #2754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 28, 2015
misteroneill
force-pushed
the
expose-dom-helpers
branch
from
3d040ea
to
292390a
Compare
Closed
| @@ -44,6 +44,8 @@ let trackToJson_ = function(track) { | |||
| * @function textTracksToJson | |||
| */ | |||
| let textTracksToJson = function(tech) { | |||
|
|
|||
| // Cannot use $$ here because it is not an instance of Tech | |||
| let trackEls = tech.el().querySelectorAll('track'); | |||
There was a problem hiding this comment.
isn't tech here a Tech and thus it should have $$?
There was a problem hiding this comment.
It wasn't when I was working on this PR (hence the comment).
I think it makes sense to use more powerful native APIs when they are available. In this case, we use `classList` for all browsers but IE8 and IE9. Also, adds slightly more rigorous tests for these functions.
- Also adds comprehensive tests. - Exposes the function as `toggleClass` on `videojs`. - Adds the `toggleClass` method to components.
misteroneill
force-pushed
the
expose-dom-helpers
branch
from
862ed69
to
a697a2c
Compare
|
LGTM. Going to make another PR after this to fix the tracks JSON that I commented about above. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building on the
ModalDialogwork...$and$$(essentially,querySelectorandquerySelectorAllrespectively).toggleElClassfunction.videojsfunction.classNamemanipulation functions to useclassListif it's available (which is true of all supported browsers except IE8).Note: The methods are generally exposed without the
Elpart (i.e.Dom.hasElClassis exposed asvideojs.hasClass). The reason for this is parity with popular JS libraries (jQuery, etc) that people are familiar with.