Improved logic for dividing rtmp path up into connection and stream part

[JacobRichardt]

This is a fix for #2776

[pam]

Tests passed. Automated cross-browser testing via Sauce Labs and Travis CI shows that the JavaScript changes in this pull request are: CONFIRMED

Commit: fc048a0
Build details: https://travis-ci.org/pam/video.js/builds/89758704

(Please note that this is a fully automated comment.)

[gkatsev]

@bdeitte does this seem ok to you?

[bdeitte]

@gkatsev This seems fine to me. I was going to suggest a test for this as well, and I added a simple one locally that I expected to fail (and was going to then just suggest it added in here where it should work). But when I run "grunt test" locally on master, it passes. And I don't see unit tests listed in the build file. What obvious thing am I missing here? Here's the test in any case, to add within 'test steamToParts' in test/unit/tech/flash-rtmp.test.js:

  parts = Flash.streamToParts('http://myurl.com/really?streaming=fun&really=fun');
  ok(parts.connection === 'http://myurl.com/');
  ok(parts.stream === 'really?streaming=fun&really=fun');

[bdeitte]

I realized right now that the test problem was PEBCAK. As penance, I'll add the test here in a new PR shortly.

[gkatsev]

Thanks! Merged this manually to give credit to you both. 4e395b6 and a25c4c9 and 977eedd