Check a component is a function before new-ing #2814
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests failed. Automated cross-browser testing via Sauce Labs and Travis CI shows that the JavaScript changes in this pull request are: BUSTED Commit: 7c22e6d54ecb098f009407365a0e2112bd1094a4 (Please note that this is a fully automated comment.) |
| // component class can be instantiated. | ||
| if (typeof ComponentClass !== 'function') { | ||
| return null; | ||
| }; |
If third-party code placed a non-Component onto the video.js object and then that same name was referenced in player options, we would try to new that third-party object whether it was a function or not. Check ahead of time and skip things that are obviously not Components.
dmlap
force-pushed
the
check-components-before-newing
branch
from
7c22e6d to
625f01c
Compare
|
Tests passed. Automated cross-browser testing via Sauce Labs and Travis CI shows that the JavaScript changes in this pull request are: CONFIRMED Commit: 625f01c (Please note that this is a fully automated comment.) |
dmlap
added a commit
to dmlap/videojs-contrib-hls
that referenced
this pull request
Nov 15, 2015
Separate out the source handler object from the HLS namespace. Now, videojs.Hls is an object that is used to organize exports from this library. The actual source handler prototype is now HlsHandler. Intended to be defensive about the backwards-compatibility concerns in videojs/video.js#2814.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If third-party code placed a non-Component onto the video.js object and then that same name was referenced in player options, we would try to new that third-party object whether it was a function or not. Check ahead of time and skip things that are obviously not Components.