fix for returning current souce rather than blob #2833
Conversation
|
Tests passed. Automated cross-browser testing via Sauce Labs and Travis CI shows that the JavaScript changes in this pull request are: CONFIRMED Commit: 339f867 (Please note that this is a fully automated comment.) |
|
LGTM |
|
Could use a test but otherwise looks good. |
|
Tests failed. Automated cross-browser testing via Sauce Labs and Travis CI shows that the JavaScript changes in this pull request are: BUSTED Commit: e3c311c (Please note that this is a fully automated comment.) |
| @@ -249,6 +249,12 @@ if (Html5.supportsNativeTextTracks()) { | |||
| equal(adds[2][0], rems[2][0], 'removetrack event handler removed'); | |||
| }); | |||
| } | |||
| test('should always return currentSource_ if set', function(){ | |||
| let currentSrc = Html5.prototype.currentSrc; | |||
| equal(currentSrc.call({el_: {currentSrc:"test1"}}), "test1", "sould return source from element if nothing else set"); | |||
There was a problem hiding this comment.
Build is failing. These should be single quotes.
|
Tests failed. Automated cross-browser testing via Sauce Labs and Travis CI shows that the JavaScript changes in this pull request are: BUSTED Commit: bf31032 (Please note that this is a fully automated comment.) |
|
@pam retry |
|
Tests passed. Automated cross-browser testing via Sauce Labs and Travis CI shows that the JavaScript changes in this pull request are: CONFIRMED Commit: bf31032 (Please note that this is a fully automated comment.) |
No description provided.