Errors fixes #2850
Closed
Errors fixes #2850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
gkatsev
commented
Nov 24, 2015
gkatsev
commented
- hide the error display properly when clearing out an error
- allow clearing an error from the an error event handler
Triggers are synchronous so, if you are trying to disable the error in an error handler, you end up throwing an error because the log line refers to this.error_ which would then get cleared up when error(null) is called.
|
Tests passed. Automated cross-browser testing via Sauce Labs and Travis CI shows that the JavaScript changes in this pull request are: CONFIRMED Commit: b2e67ce (Please note that this is a fully automated comment.) |
gkatsev
added
patch
|
LGTM. We'll open a separate issue to trigger some kind of event when an error is removed/ |
|
Done #2851 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.