Fix keyboard (Space or Enter) operation of buttons. Fixes #2888. #2889
Conversation
| attributes = assign({ | ||
| role: 'button', |
There was a problem hiding this comment.
is it bad to just have both assigned? Or just to make the final markup simpler?
There was a problem hiding this comment.
If by 'both' you mean the element tag and the role, then see https://www.w3.org/TR/html5/dom.html#aria-usage-note:
NOTE: In the majority of cases setting an ARIA role and/or aria-* attribute that matches the default implicit ARIA semantics is unnecessary and not recommended as these properties are already set by the browser.
There has been further discussion about this within W3C, but that's the current recommendation.
The type attribute needs to be set on a <button> element, as noted in the comment.
|
Have a question about role/type attributes. |
|
Going to close this because it's getting merged as part of #2897. |
When video.js moved to using button elements instead of DIVs for buttons in V5, it kept the keyboard handling to simulate a click on Space or Enter key press, even though the browser does this for buttons. This causes an issue with Firefox when performing keyboard operation of buttons like the Play/Pause button.