Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing some broken links in guides #2965

Closed
wants to merge 1 commit into from
Closed

fixing some broken links in guides #2965

wants to merge 1 commit into from

Conversation

rcrooks
Copy link
Contributor

@rcrooks rcrooks commented Jan 3, 2016

Fixing a few broken links in the Guides -- merge please.

@@ -153,7 +153,7 @@ Language Codes
--------------
The following is a list of official language codes.

**NOTE:** For supported language translations, please see the [Languages Folder (/lang)](../../lang) folder located in the project root.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This relative URL seems to work fine on Github, where's the problem?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These docs don't really live on github anymore -they get copied to the/docs
repo and deployed on docs.videojs.com, so the links have to be fixed for
that.

On Sun, Jan 3, 2016 at 19:20 Thijs Triemstra notifications@github.com
wrote:

In docs/guides/languages.md
#2965 (comment):

@@ -153,7 +153,7 @@ Language Codes


The following is a list of official language codes.

-NOTE: For supported language translations, please see the Languages Folder (/lang) folder located in the project root.

This relative URL seems to work fine on Github, where's the problem?


Reply to this email directly or view it on GitHub
https://github.com/videojs/video.js/pull/2965/files#r48699395.

Robert Crooks
Director of Learning Services
Brightcove, Inc

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, +1

@gkatsev
Copy link
Member

gkatsev commented Jan 4, 2016

LGTM

@gkatsev gkatsev added confirmed patch This PR can be added to a patch release. labels Jan 4, 2016
@gkatsev gkatsev closed this in 0f219b1 Jan 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
confirmed patch This PR can be added to a patch release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants