Improve UX of current time tooltip #3060
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| right: -1.5em; | ||
| font-size: 0.9em; | ||
| color: #000; | ||
| content: attr(data-current-time); | ||
| padding: 0.2em 0.5em; | ||
| padding: 6px 8px 8px 8px; |
There was a problem hiding this comment.
Shouldn't it have equal padding on top/bottom?
There was a problem hiding this comment.
It is visually equal with this CSS. Probably due to the font.
There was a problem hiding this comment.
I'm seeing it larger on the bottom.
There was a problem hiding this comment.
What browser? This is what I'm seeing in Chrome:
There was a problem hiding this comment.
Chrome. I'm definitely seeing it as 6px and 8px.
There was a problem hiding this comment.
So, after looking careful at it with @incompl, the computed style does actually lie here. What was causing as issue is the slight overlap of the control bar which caused it to look wrong to me. This is fixed by the latest commit to the PR.
gkatsev
added
minor
|
LGTM |
gkatsev
added
confirmed
and removed
needs: LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.