Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ISSUE_TEMPLATE for github. #3117

Closed
wants to merge 5 commits into from
Closed

Conversation

gkatsev
Copy link
Member

@gkatsev gkatsev commented Feb 17, 2016

@dmlap
Copy link
Member

dmlap commented Feb 17, 2016

Cool! Notes:

  • link to jsbin.com/axedog for the reduced test cases?
  • The STR numbering doesn't render correctly in github markdown right now

@gkatsev
Copy link
Member Author

gkatsev commented Feb 17, 2016

Yeah, the number doesn't render correctly without content. When new issues are included, they're in "write" mode and not "preview" mode, so, it should be OK.

@dmlap
Copy link
Member

dmlap commented Feb 17, 2016

The PR template is awesome for new features. I wouldn't want to set the bar that high for simple bug fixes, though. Any way to split the difference?

@gkatsev
Copy link
Member Author

gkatsev commented Feb 17, 2016

Not sure. A lot of that applies should apply to "simple bug fixes" as well. Maybe we just need better/simpler wording.

@gkatsev gkatsev added patch This PR can be added to a patch release. needs: LGTM Needs one or more additional approvals labels Feb 17, 2016
@heff
Copy link
Member

heff commented Feb 17, 2016

Nice! Love this feature. lgtm

@gkatsev
Copy link
Member Author

gkatsev commented Feb 18, 2016

@dmlap I updated the wording in the PR Template. Please take another look.

@dmlap
Copy link
Member

dmlap commented Feb 18, 2016

👍

@gkatsev gkatsev added confirmed and removed needs: LGTM Needs one or more additional approvals labels Feb 18, 2016
@gkatsev gkatsev closed this in 050f23d Feb 18, 2016
@gkatsev gkatsev deleted the issue-templates branch February 18, 2016 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
confirmed patch This PR can be added to a patch release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants