Reset ltr direction on control bar and spinner #3221
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If the player is inheriting
rtl
directionality, the control bar order reverses as flex boxrow
order follows text direction. The loading spinner animation is also broken as the circles are not aligned. This PR resets the direction on those components toltr
, allowing the rest of the player, especially dialogs with localised text to inheritrtl
.Fixes #3204
Specific Changes proposed
Adds
dir="ltr"
to the ControlBar and LoadingSpinner componentsRequirements Checklist