Pass tech options to source handlers #3245
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We don't really have documentation for source handlers :( |
gkatsev
added
minor
|
@nickygerritsen we don't have any official documentation for them (which I am sad about). heff did a pretty good job of doc'ing them in his original PR though. It would be great to get all that info into our docs at some point. |
| @@ -714,7 +714,7 @@ Tech.withSourceHandlers = function(_Tech){ | |||
| this.off('dispose', this.disposeSourceHandler); | |||
|
|
|||
| this.currentSource_ = source; | |||
| this.sourceHandler_ = sh.handleSource(source, this); | |||
| this.sourceHandler_ = sh.handleSource(source, this, this.options_); | |||
|
LGTM |
gkatsev
added
confirmed
and removed
needs: LGTM
nickygerritsen
pushed a commit
to StreamOneNL/video.js
that referenced
this pull request
Apr 13, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR passes the whole
tech's options to a source handler inhandleSource, as discussed in #2616. Note that that PR also mentions things aboutsourceHandlerOrderbut I think that has nothing to do with passing options, so I did not add that. If desired, I can create a separate PR for this.As far as my
grepskills are accurate, I could not find any documentation that explains how source handlers work. If this is somewhere, let me know so I can add it there as well.Specific Changes proposed
This just adds the options to
handleSource. I also cleaned up some documentation and added a test for this. Furthermore I added the options argument to allhandleSourcecalls done internally, although it is not used anywhere yet.Requirements Checklist