Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blacklist Android Chrome for playback rate support #3246

Closed
wants to merge 1 commit into from
Closed

Blacklist Android Chrome for playback rate support #3246

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/js/control-bar/playback-rate-menu/playback-rate-menu-button.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,9 +119,10 @@ class PlaybackRateMenuButton extends MenuButton {
}

/**
* Get supported playback rates
* Get whether playback rates is supported by the tech
* and an array of playback rates exists
*
* @return {Array} Supported playback rates
* @return {Boolean} Whether changing playback rate is supported
* @method playbackRateSupported
*/
playbackRateSupported() {
Expand Down
7 changes: 6 additions & 1 deletion src/js/tech/html5.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -935,9 +935,14 @@ Html5.canControlVolume = function(){
/*
* Check if playbackRate is supported in this browser/device.
*
* @return {Number} [description]
* @return {Boolean}
*/
Html5.canControlPlaybackRate = function(){
// Playback rate API is implemented in Android Chrome, but doesn't do anything
// https://github.com/videojs/video.js/issues/3180
if (browser.IS_ANDROID && browser.IS_CHROME) {
return false;
}
var playbackRate = Html5.TEST_VID.playbackRate;
Html5.TEST_VID.playbackRate = (playbackRate / 2) + 0.1;
return playbackRate !== Html5.TEST_VID.playbackRate;
Expand Down