Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use function statement for videojs #3357

Closed
wants to merge 1 commit into from
Closed

Use function statement for videojs #3357

wants to merge 1 commit into from

Conversation

gkatsev
Copy link
Member

@gkatsev gkatsev commented Jun 6, 2016

Description

This is a fix for IE8 where the name of a named function
expression is different from the variable that function is
assigned to. This is an issue because our version of babel outputs
functions like that.
Fixes #3064 again.

Requirements Checklist

  • Feature implemented / Bug fixed
  • Reviewed by One Core Contributors

This is a fix for IE8 where the name of a named function
expression is different from the variable that function is
assigned to. This is an issue because our version of babel outputs
functions like that.
Fixes #3064 again.
@gkatsev gkatsev force-pushed the fix-ie8-videojs branch from 846ceb4 to b9cc347 Compare June 6, 2016 22:37
@gkatsev
Copy link
Member Author

gkatsev commented Jun 7, 2016

codeship is succeeding but timing out for some reason.

@misteroneill
Copy link
Member

LGTM

@gkatsev gkatsev added confirmed patch This PR can be added to a patch release. labels Jun 7, 2016
@gkatsev gkatsev closed this in 8d5a1b1 Jun 7, 2016
@gkatsev gkatsev deleted the fix-ie8-videojs branch June 7, 2016 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
confirmed patch This PR can be added to a patch release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants