Remove unused loadEvent property in ControlBar options #3363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. |
gkatsev
added
patch
|
It's a relic. Something where it wouldn't initialize until the play event happened (after the big play button was clicked). Can't believe it made it through all 5.0 work. It's a survivor! |
gkatsev
added
confirmed
and removed
needs: LGTM
|
merged to stable. Will be closed when released and merged to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ControlBar's default options currently contains a misleadingloadEventproperty.Looking through the code (
grep -irl loadEvent --exclude-dir=node_modules *) shows that this property is not used anywhere.Specific Changes proposed
Remove an unused property.
Requirements Checklist