Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't use VideoJS font for menu text #3384

Closed
wants to merge 1 commit into from
Closed

Don't use VideoJS font for menu text #3384

wants to merge 1 commit into from

Conversation

mister-ben
Copy link
Contributor

Description

Similar to #3213, the VideoJS font shouldn't be used for menu content as the browser fallback font will be used.

Specific Changes proposed

Use $text-font-family for .vjs-menu .vjs-menu-content

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
  • Reviewed by Two Core Contributors

@gkatsev
Copy link
Member

gkatsev commented Jun 21, 2016

LGTM.

@gkatsev gkatsev added confirmed patch This PR can be added to a patch release. labels Jun 21, 2016
@gkatsev gkatsev closed this in 4355179 Jun 28, 2016
@mister-ben mister-ben deleted the fix-menu-font branch August 10, 2016 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
confirmed patch This PR can be added to a patch release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mister-ben @gkatsev