Respect lang attribute on player and inherit correctly #3426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. |
gkatsev
added
confirmed
minor
|
@mister-ben hey, looks like some of the tests are failing in IE, would you be able to take a look? See https://travis-ci.org/videojs/video.js/builds/145628625 (ignore the flash duration and logging tests) |
|
Ack. Will check next week when I'm back from holiday. |
|
@mister-ben cool, I might end up fixing it myself. Would like to get a release out this week, if possible. I'll make sure to write here whether I managed to fix it or not. |
|
Figured it out. A pretty silly issue that's super hard to find: #3455 |
| } | ||
| } else { | ||
| let element = tag; | ||
| while (element && element.nodeType === 1) { |
There was a problem hiding this comment.
Suggest you use ... && element.nodeType === Node.ELEMENT_NODE here for clarity (see https://developer.mozilla.org/en-US/docs/Web/API/Node/nodeType).
|
@gkatsev sorry about that. Thanks for sorting it out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, if language isn't set in the player options language will be determined by the
langattribute of thehtmlelement if set before falling back to the browser language preference.langshould be respected if present on the video element. If not present, lang should be inherited from the closest element with it set up to and including html.Specific Changes proposed
Checks for closest element with a
langattribute, not justhtml. The check is made in constructor rather than options prototype, as it needs to be relative to the specific player instance. A language in the player options still takes precedence.Requirements Checklist