-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new build that outs source es6 files into es5 folder #3445
Changes from all commits
8cecf54
a6e896f
5501186
eb26a7e
3146ec3
8f3ad4e
f508af5
ab87184
d5e0437
20929fc
788c3a3
c66ef7e
995b151
99e0674
532d868
6c74dab
f234446
e77bb4b
23ec89d
560047f
163c7dc
fd690c2
7a86fdc
fe00483
6c65b26
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
{ | ||
"presets": ["es2015-loose"], | ||
"plugins": ["transform-es3-property-literals", "transform-es3-member-expression-literals", "inline-json"] | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -28,5 +28,6 @@ test/coverage/* | |
.sass-cache | ||
|
||
dist/* | ||
es5/* | ||
|
||
.idea/ |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,5 @@ | ||
# Exclude everything but the contents of the dist directory. | ||
**/* | ||
!dist/** | ||
!es5/** | ||
!src/css/** |
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -13,7 +13,7 @@ import EventTarget from './event-target'; | |
import * as Events from './utils/events.js'; | ||
import Player from './player'; | ||
import plugin from './plugins.js'; | ||
import mergeOptions from '../../src/js/utils/merge-options.js'; | ||
import mergeOptions from './utils/merge-options.js'; | ||
import * as Fn from './utils/fn.js'; | ||
import TextTrack from './tracks/text-track.js'; | ||
import AudioTrack from './tracks/audio-track.js'; | ||
|
@@ -132,7 +132,7 @@ setup.autoSetupTimeout(1, videojs); | |
* | ||
* @type {String} | ||
*/ | ||
videojs.VERSION = '__VERSION__'; | ||
videojs.VERSION = require('../../package.json').version; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I assume this is where the babel plugin comes in, my question is: Why even bother trying to make it a literal? We could just use it like this and have rollup shake off everything from the package.json that we don't use (effectively making it literal anyway). There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It would mean that anyone who wants to require videojs will need to use rollup or whatever to exclude everything. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ok that makes sense |
||
|
||
/** | ||
* The global options object. These are the settings that take effect | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -29,12 +29,7 @@ module.exports = function(config) { | |
browserify: { | ||
debug: true, | ||
plugin: ['proxyquireify/plugin'], | ||
transform: [ | ||
require('babelify').configure({ | ||
sourceMapRelative: './', | ||
loose: ['all'] | ||
}) | ||
] | ||
transform: ['babelify'] | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. gets configured via |
||
}, | ||
|
||
plugins: [ | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is so that the babel json config plugin doesn't try and replace this.