vjsstandard - Tests - Bottom half of test/unit #3477
Conversation
| } | ||
| } | ||
| }); | ||
|
|
||
| player.dispose(); | ||
| }); | ||
|
|
||
| test('Plugin should have the option of being initilized outside of player init', function(){ | ||
| expect(3); | ||
| QUnit.test('Plugin should have the option of being initilized ' + |
There was a problem hiding this comment.
I wonder if it's possible to tell eslint to ignore the long lines rule for tests.
There was a problem hiding this comment.
It's just a warning; so, I've been ignoring them.
There was a problem hiding this comment.
yeah its just a warning and I could put it back to the full line if we want
There was a problem hiding this comment.
we could use "ignorePattern": /.*test(.* on the max-len rule or some similar regex. to turn it off for test names, or maybe test names should never be this long?
brandonocasey
changed the title
move loop iterator into for loop
|
re-commenting on the we could use "ignorePattern": /.test(. on the max-len rule or some similar regex. to turn it off for test names, or maybe test names should never be this long? |
|
In other projects, I'm using QUnit.test(tsmlj`
this is a really long test name. it has a whole bunch of characters - even more
than 80 or the warning limit of 90!
`, function(assert) {
// ...
}); |
|
LGTM |
| import {IE_VERSION} from '../../src/js/utils/browser'; | ||
| import registerPlugin from '../../src/js/plugins.js'; | ||
| import Player from '../../src/js/player.js'; | ||
| import TestHelpers from './test-helpers.js'; | ||
| import window from 'global/window'; | ||
| import sinon from 'sinon'; |
There was a problem hiding this comment.
if we're importing sinon directly, we should remove it from the global-shim.js file.
|
A couple of minor comments. |
fix spacing of an assertion
misteroneill
force-pushed
the
vjsstandard-core
branch
from
deddb6b to
caf614e
Compare
Description
lint the bottom half of the files in the test/unit directory with
videojs-standardRequirements Checklist