-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the language table in the docs #3493
Conversation
Does this doc need to list language codes? Something like this from the explanation of Navigator.language on MDN might suffice:
|
I'm all for leaving the table out - especially when there's a link directly to an always-updated list of files/languages. This seems like wasteful documentation. |
yeah that works too, I can just change it to a link |
I think the original idea was to have the list of names for the json files in an easily accessible place. |
The problem I see there is that you then have to remember to update this document anytime a new file is added/removed. Not that it's a common occurrence, but... |
this list has all* the languages, not just the ones currently available in videojs. *not actually all, but a large selection of the most commonly used languages |
Oh, I see, then ignore me. :) |
@gkatsev @mister-ben @misteroneill So the consensus here is to change the table into a link right? How about this? |
link to an external website that contains all possible languages
LGTM |
LGTM |
Description
Noticed that the language table on http://docs.videojs.com/docs/guides/languages.html is not correctly formatted. Looked at the markdown file for it and saw some malformed HTML. Fixed it
Requirements Checklist