Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do a nullcheck for navigator. default to null for ios_version #3502

Closed
wants to merge 2 commits into from

Conversation

gkatsev
Copy link
Member

@gkatsev gkatsev commented Aug 5, 2016

This allows us to require videojs in node or tonicdev.com

const browser = require('./browser.js');
console.log(browser);
{ IS_IPAD: false,
  IS_IPHONE: false,
  IS_IPOD: false,
  IS_IOS: false,
  IOS_VERSION: null,
  IS_ANDROID: false,
  ANDROID_VERSION: null,
  IS_OLD_ANDROID: false,
  IS_NATIVE_ANDROID: false,
  IS_FIREFOX: false,
  IS_EDGE: false,
  IS_CHROME: false,
  IS_IE8: false,
  IE_VERSION: null,
  TOUCH_ENABLED: false,
  BACKGROUND_SIZE_SUPPORTED: false }

/cc @ljharb

@gkatsev gkatsev added this to the 3.12 build-improvements milestone Aug 5, 2016
@gkatsev gkatsev added the needs: LGTM Needs one or more additional approvals label Aug 5, 2016
@misteroneill
Copy link
Member

There's another navigator.userAgent here.

@misteroneill
Copy link
Member

LGTM

@gkatsev gkatsev added confirmed and removed needs: LGTM Needs one or more additional approvals labels Aug 5, 2016
@gkatsev gkatsev closed this in f947ed7 Aug 5, 2016
@gkatsev gkatsev deleted the user-agent branch August 5, 2016 18:39
@ljharb ljharb mentioned this pull request Aug 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants