Qunit 2 Style #3509
Closed
Qunit 2 Style #3509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
misteroneill
force-pushed
the
qunit-2-style
branch
3 times, most recently
from
9a6c22b to
10b4491
Compare
|
some of these commits are from your other PR #3508. Also we should probably update qunitjs to version 2 (maybe even karma-qunit too?) |
| @@ -24,23 +24,23 @@ const cleanup = (item) => { | |||
| }; | |||
|
|
|||
| if (Html5.supportsNativeTextTracks()) { | |||
| QUnit.test('trackToJson_ produces correct representation for native track object', function(a) { | |||
| QUnit.test('trackToJson_ produces correct representation for native track object', function(assert) { | |||
There was a problem hiding this comment.
nice it actually changed these from a to assert 👍
|
@brandonocasey Good call on updating QUnit maybe. Also, the extra commits are due to rebasing. Once that PR is merged, I'll rebase this one again. |
misteroneill
added
needs: LGTM
|
LGTM |
misteroneill
added
confirmed
and removed
needs: LGTM
gkatsev
added
the
minor
|
Oops, I forgot that karma-qunitjs is being updates here as well. |
|
Could you rebase against master? |
The tool was imperfect and I had to do a lot of search/replace to fix it. And it broke a few tests.
misteroneill
force-pushed
the
qunit-2-style
branch
from
527801c to
6aa4ae1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This updates tests to use QUnit 2.0-style assertions and test module lifecycle methods.
Specific Changes proposed
QUnit.ok()orok()style toassert.ok()style.setup()withbeforeEach()andteardown()withafterEach().Requirements Checklist