Stop Android treating swipe as tap #3514
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me. Thanks for catching that @mister-ben! |
|
I have this problem on firefox 50 and video.js 5.16.0 (laptop convertible to tablet) |
akashta
pushed a commit
to hola/video.js
that referenced
this pull request
Apr 13, 2017
Conflicts: CHANGELOG.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
On Android, a short duration swipe is always considered a tap. Scrolling a page can easily start playback unintentionally - see #3157.
assign()returns{}in the touchstart handler, sotouchDistanceis alwaysNaNin the touchmove handler.It seems
pageX,pageYetc are "own" properties of the Touch on iOS Safari (and of the object used in the tests) but not on Android Chrome, hence the difference in behaviour ofassign().Specific Changes proposed
Copy the specific properties needed instead of using
assign(). Unless I'm missing something about the point of usingassign()in the first place...Requirements Checklist