Silence "The play() request was interrupted by a call to pause()" #3518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // Catch/silence error when a pause interrupts a play request | ||
| // on browsers which return a promise | ||
| if (playPromise !== undefined) { | ||
| playPromise.catch((e) => {}); |
There was a problem hiding this comment.
catch might be an issue on IE8.
Also, we should probably verify this is a promise before proceeding.
There was a problem hiding this comment.
OK, reworked that.
| @@ -517,3 +517,20 @@ QUnit.test('Html5#reset calls Html5.resetMediaElement when called', function() { | |||
|
|
|||
| Html5.resetMediaElement = oldResetMedia; | |||
| }); | |||
|
|
|||
| QUnit.test('Exception in play promise should be caught', function() { | |||
There was a problem hiding this comment.
I think this test should be wrapped in a condition to check for Promise support. When it gets merged and runs in a browser that doesn't support Promise it will likely blow up.
There was a problem hiding this comment.
we're running es6-shim on tests, so, Promise is always available.
|
In that case, LGTM |
|
LGTM |
|
This fixes #3474 |
Merged
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
On browsers that return a promise for
play()(so far Chrome), anAbortErrorDOMException is thrown if apause()occurs before playback starts. This doesn't break anything, but logs an annoying error to the console.Specific Changes proposed
Just catch the exception and do nothing.
Requirements Checklist