disable the audio tracks that were not clicked on. #3538
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I did not see any existing unit tests for this class, did manual testing only.
|
Thanks for the PR! The format looks fine from what I can tell. I think that I think this looks good to me and through some of my own tests I can confirm that it works. LGTM |
|
Yeah, this LGTM. And the code is cleaner, IMHO. |
gkatsev
pushed a commit
that referenced
this pull request
Aug 24, 2016
|
Merged to stable. |
helenjer
pushed a commit
to helenjer/video.js
that referenced
this pull request
Sep 6, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When an audio track menu item is clicked, the other audio tracks should be disabled. Potential fix for #3510.
Specific Changes proposed
In the AudioTrackMenuItem click handler, disable the tracks that were not clicked on, in addition to enabling the track that was clicked on.
Requirements Checklist
I did not see any existing unit tests for this class, did manual testing only.
(FWIW,
contrib feature submitjust printed "undefined" after I entered the description and didn't seem to create a pull request so I did this through Github. Apologies if this is not formatted as you desire.)