Fix MediaError #3560
Closed
Fix MediaError #3560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| // We assign the `code` property manually because native MediaError objects | ||
| // do not expose it as an own/enumerable property of the object. | ||
| if (typeof value.code === 'number') { |
There was a problem hiding this comment.
should we copy this before the assign?
There was a problem hiding this comment.
Hmm. Not sure there's a case where there would be a difference in behavior.
|
Can you rebase/change this PR against the stable branch? |
|
Two things, LGTM otherwise. |
|
Yeah, will rebase tomorrow morning. |
misteroneill
force-pushed
the
fix-media-error
branch
from
c42f6af to
0253742
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We discovered that attempting to construct a video.js
MediaErrorobject would fail to properly copy a nativeMediaErrorobject due to thecodeproperty being non-enumerable. Additionally, there were no tests for this module.Specific Changes proposed
MediaErrorobjects from nativeMediaErrorobjects by manually assigning thecodeproperty.MediaErrorobject to be redundantly constructed, such that if it is called with a video.jsMediaErrorobject, it simply returns the same object. This removes the need for two code forks found elsewhere in the code.Requirements Checklist