Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proxy ios webkit events into fullscreenchange #3644

Merged
merged 5 commits into from
Sep 29, 2016
Merged

Proxy ios webkit events into fullscreenchange #3644

merged 5 commits into from
Sep 29, 2016

Commits on Sep 29, 2016

  1. Proxy ios webkit events into fullscreenchange 

    Previously, the ios webkit events (webkitbeginfullscreen and
webkitendfullscreen) were only proxied into the fullscreenchange event
when requestFullscreen was called directly. So, on iPhones, we would
never be able to get this event. This makes it so these events are
always proxied.
    @gkatsev
    gkatsev committed Sep 29, 2016
    Configuration menu
    Copy the full SHA
    c76a8da View commit details
    Browse the repository at this point in the history

  2. fix handlers

    @gkatsev
    gkatsev committed Sep 29, 2016
    Configuration menu
    Copy the full SHA
    7475b86 View commit details
    Browse the repository at this point in the history

  3. extra whitespace

    @gkatsev
    gkatsev committed Sep 29, 2016
    Configuration menu
    Copy the full SHA
    dcf8423 View commit details
    Browse the repository at this point in the history

  4. Refactor endFn into a separate function to be disposed. Remove 'webki… 

    …t' from var names
    @gkatsev
    gkatsev committed Sep 29, 2016
    Configuration menu
    Copy the full SHA
    5b0d6d2 View commit details
    Browse the repository at this point in the history

  5. remove some nesting

    @gkatsev
    gkatsev committed Sep 29, 2016
    Configuration menu
    Copy the full SHA
    cf01084 View commit details
    Browse the repository at this point in the history