fix: currentDimension can return 0 for fluid player on IE #3738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is because IE returns 0 for both getComputedStyle and currentStyle. However, offsetHeight and offsetWidth do contain the correct values we want. So, if before returning in currentDimension the return value is still zero, check the offset values.
gkatsev
commented
Nov 3, 2016
| @@ -1149,15 +1149,20 @@ class Component { | |||
|
|
|||
| computedWidthOrHeight = computedStyle.getPropertyValue(widthOrHeight) || computedStyle[widthOrHeight]; | |||
| } else if (this.el_.currentStyle) { | |||
| // ie 8 doesn't support computed style, shim it | |||
| // return clientWidth or clientHeight instead for better accuracy | |||
| computedWidthOrHeight = this.el_.currentStyle[widthOrHeight]; | |||
There was a problem hiding this comment.
try and use currentStyle on IE, if available.
mister-ben
approved these changes
Nov 3, 2016
mister-ben
reviewed
Nov 3, 2016
| @@ -1155,7 +1155,7 @@ class Component { | |||
|
|
|||
| // if the computed value is still 0, it's possible that the browser is lying | |||
| // and we want to check the offset values. | |||
| // This code also runs on IE8 and whereever getComputedStyle doesn't exist. | |||
| // This code also runs on IE8 and where-ever getComputedStyle doesn't exist. | |||
| if (computedWidthOrHeight === 0) { | |||
There was a problem hiding this comment.
haha, thanks. I'll update it before merging.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is because IE returns 0 for both getComputedStyle and currentStyle.
However, offsetHeight and offsetWidth do contain the correct values we
want. So, if before returning in currentDimension the return value is
still zero, check the offset values.