fix hooks unit test in ie8 #3745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandonocasey
commented
Nov 4, 2016
| @@ -107,14 +107,14 @@ function videojs(id, options, ready) { | |||
| } | |||
|
|
|||
| videojs.hooks('beforesetup').forEach(function(hookFunction) { | |||
| const opts = hookFunction(tag, videojs.mergeOptions({}, options)); | |||
| const opts = hookFunction(tag, mergeOptions(options)); | |||
There was a problem hiding this comment.
it was silly to use videojs. here but not really a necessary change.
brandonocasey
commented
Nov 4, 2016
| @@ -336,7 +336,7 @@ QUnit.test('beforesetup options override videojs options', function(assert) { | |||
|
|
|||
| const vid = document.getElementById('test_vid_id'); | |||
|
|
|||
| videojs.hook('beforesetup', function(options) { | |||
| videojs.hook('beforesetup', function(tag, options) { | |||
There was a problem hiding this comment.
I guess video tags in ie8, don't have an autoplay property... whoops
There was a problem hiding this comment.
Ah, yeah, you have to do getAttribute on IE8. Heh, that's pretty funny.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix a unit test in ie8 that is currently broken
Requirements Checklist