Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix broken logo link in README and docs #6345

Merged
merged 1 commit into from
Dec 3, 2019

Conversation

dylanjha
Copy link
Contributor

@dylanjha dylanjha commented Dec 3, 2019

depends on videojs/videojs.com#112

closes #6340

Description

video.js logo is broken in this README and on the docs site (#6340 )

Specific Changes proposed

Update the link to point to a valid image url (waiting for videojs/videojs.com#112 to be merged)

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
    • Change has been verified in an actual browser (Chome, Firefox, IE)
    • Unit Tests updated or fixed
    • Docs/guides updated
    • Example created (starter template on JSBin)
  • Reviewed by Two Core Contributors

@welcome
Copy link

welcome bot commented Dec 3, 2019

💖 Thanks for opening this pull request! 💖

Things that will help get your PR across the finish line:

  • Run npm run lint -- --errors locally to catch formatting errors earlier.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@gkatsev gkatsev merged commit 274299b into videojs:master Dec 3, 2019
@welcome
Copy link

welcome bot commented Dec 3, 2019

Congrats on merging your first pull request! 🎉🎉🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Logo image link in documentation is broken.
3 participants