Fix Player.buffered() to more correct behavior #643
Conversation
The problem is that Player.buffered() always return the first time range. This means that while do seeking threough the timeline, progress loader is not updated as far as browser send new buffering info at the tail of buffered time-ranges, so, looks like it would be more correctly to grab this info from the last time-range object rather than from the first one.
|
Interesting, I didn't realize the browsers were finally using more than one range. That means we could build a loader bar with multiple ranges now. This looks like a good update to me. Could you remove the extra space before buflen in the parenthesis |
|
I'm not actually sure that all browsers do that in the same way (but at least Chrome, Opera and FF looks like do due to my investigations). But at least those which do that in current implementation will behave more correctly with the buffer bar. BTW, to make multiple ranges on a bar it will also require implement support for passing correct ranges in flash fallback. That's just to not forget about this :) |
|
Yeah, good thought. The flash fallback doesn't support pseudo streaming yet, so we'll only have one range in Flash for the time being anyway. |
|
I'd be glad to help add pseudo-streaming to flash, but it requires some effort I can't provide at present time. For my mutual project based on videojs I'd added this support but it was done not in generic way and for MP4 only. BTW, if someone will decide to do that in nearest future, that's what I could mention. Do not forget to add NetworkStream and NetworkConnection close() calls to adapters' die() methods. Without that there would be really funny effects like interfered sound effects from old piece of video :) If after some time there would be no one who work on this task, I'll probably take a part, but right now I can't do any promise on that. |
|
No problem. Thanks for the tip! |
|
You'r welcome, thank you for the great project, it helps a lot! BTW, seems like Tom-Johnson already fixed 2 weeks ago a problem stated by me above (just looked to Flash source code) :) So my tip is not so useful as I expected it could be :) |
|
Great, even better. :) |
|
So, looks like you are not going to merge this, or you just forgot to do this? Seems like I did all the changes you requested for this fix |
|
No, it's merged. I use Pulley for pull requests, which merges locally instead of through Github, so can look a little weird. But check the commit log. You're in there. |
|
Ok, thanks a lot, I just wait for it to update my code with new videoj src
|
The problem is that Player.buffered() always return the first time range. This means that while do seeking through the timeline, progress loader is not updated as far as browser sends new buffering info at the tail of buffered time-ranges, so, looks like it would be more correctly to grab this info from the last time-range object rather than from the first one.