Export addClass and removeClass

[sansb]

Would like to have addClass and removeClass available on player. Useful for stuff like adding a 'preroll' class when showing preroll.

[heff]

Would you miss fadeIn/fadeOut if I killed it? I'm working on some big control bar changes, where I've moved the fading back to the control bar itself, and based it on states of the video.

/* Hide the control bar when the video is playing and the user is passive  */
.vjs-default-skin.vjs-has-started.vjs-user-passive.vjs-playing .vjs-control-bar {
  display: block;
  visibility: hidden;
  opacity: 0;

  @trans: visibility 1.0s, opacity 1.0s;
  .transition(@trans);
}

https://github.com/heff/video-js/blob/feature/control-bar-fixes/src/css/video-js.less#L175

[sansb]

I would not! This is the only reason I needed fadeIn/fadeOut- https://gist.github.com/sansb/6122588. It's a plugin that monitors user mouse activity and hides the controls if the mouse doesn't move for some amount of time. It looks like your control bar updates do exactly this, so I would no longer need fadeIn/fadeOut.

[heff]

Ok, awesome.

On Jul 31, 2013, at 7:44 AM, Sean Bloomfield notifications@github.com wrote:

I would not! This is the only reason I needed fadeIn/fadeOut- https://gist.github.com/sansb/6122588. It's a plugin that monitors user mouse activity and hides the controls if the mouse doesn't move for some amount of time. It looks like your control bar updates do exactly this, so I would no longer need fadeIn/fadeOut.

—
Reply to this email directly or view it on GitHub.

[heff]

Got this merged in, sans fade methods since we're not using those in master anymore. Thanks.