fix(control-bar): dont crash after dispose #6977
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💖 Thanks for opening this pull request! 💖 Things that will help get your PR across the finish line:
We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can. |
brandonocasey
approved these changes
Dec 8, 2020
brandonocasey
added
needs: LGTM
gkatsev
approved these changes
Dec 11, 2020
|
Congrats on merging your first pull request! 🎉🎉🎉 |
|
Looks like this broke IE11. The TimeDisplay ends up appending rather replacing. It looks like IE11 doesn't handle text nodes with contains I'll make a PR to switch to looking at comparing the first child |
|
MDN confirms that IE11 only supports HTMLElement for contains: https://developer.mozilla.org/en-US/docs/Web/API/Node/contains#browser_compatibility. Fix here #7059 |
gkatsev
added a commit
that referenced
this pull request
Nov 9, 2021
edirub
pushed a commit
to edirub/video.js
that referenced
this pull request
Jun 8, 2023
edirub
pushed a commit
to edirub/video.js
that referenced
this pull request
Jun 8, 2023
This is another follow-up to videojs#6699. Potentially, it means we could get rid of videojs#6977
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed the change requested in #6700. Thanks to @travisbader