Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: always have an enabled audio track when switching #7163

Merged
merged 2 commits into from
Apr 6, 2021
Merged

fix: always have an enabled audio track when switching #7163

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
375385b
fix: always have an enable audio track
brandonocasey Apr 6, 2021
9efc19a
better change
brandonocasey Apr 6, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 3 additions & 7 deletions src/js/control-bar/audio-track-controls/audio-track-menu-item.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,15 +76,11 @@ class AudioTrackMenuItem extends MenuItem {
* @listens click
*/
handleClick(event) {
const tracks = this.player_.audioTracks();

super.handleClick(event);

for (let i = 0; i < tracks.length; i++) {
const track = tracks[i];

track.enabled = track === this.track;
}
// the audio track list will automatically toggle other tracks
// off for us.
this.track.enabled = true;
}

/**
Expand Down