unmute if the user drags the volume bar slider #720
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tried to write a test for this, but got stymied by the mediafaker's inability to setMute successfully. Sorry, banged my head against it for about 30 minutes before giving up... |
|
Nice. Seems straight forward enough. I think the best way to test this would be to stub the player's |
…-mousemove * upstream/master: Bump version to 4.2.1 Rotating CHANGELOG Adding line to CHANGELOG Close GH-727: Fixed windowLoaded not setting on async script load. Fixes #727 Removed sourcemap from compiled output. fixes #712 Added back in reverted #630 Fixed changelog version Rotating CHANGELOG Bump version to 4.2.0 Fixed IE8 tests and flaky fonts Fixed the getAttributes test in ie8, which reports all attrs, whether or not they were set Fixed the custom fallback message test which would break when ie8 capitalized tag names Revert "Close GH-630: prevent default action for simple html5 media events. fixes #573, fixes #620 (duplicate bug)."
|
Thanks! |
This was referenced Mar 1, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implemented recommendations on issue #538