Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Romanian language and update translations doc. #7300

Merged
merged 1 commit into from
Jul 28, 2021
Merged

Add Romanian language and update translations doc. #7300

merged 1 commit into from
Jul 28, 2021

Conversation

dykwiat
Copy link
Contributor

@dykwiat dykwiat commented Jul 1, 2021

Description

This is to add Romanian to video js.

Specific Changes proposed

Please list the specific changes involved in this pull request.

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
    • Change has been verified in an actual browser (Chrome, Firefox, IE)
    • Unit Tests updated or fixed
    • Docs/guides updated
    • Example created (starter template on JSBin)
  • Reviewed by Two Core Contributors

Tested in chrome by changing the sandbox inbox.html to use romanian:

  // added to the script section
  <script src="../dist/lang/ro.js"></script>

  // changed player to use Romanian
  var player = videojs(vid, {language: 'ro'});

Screen Shot 2021-07-01 at 4 26 33 PM

Screen Shot 2021-07-01 at 4 26 27 PM

Screen Shot 2021-07-01 at 4 26 44 PM

@welcome
Copy link

welcome bot commented Jul 1, 2021

💖 Thanks for opening this pull request! 💖

Things that will help get your PR across the finish line:

  • Run npm run lint -- --errors locally to catch formatting errors earlier.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@@ -329,8 +329,7 @@ This default value is hardcoded as a default to the localize method in the SeekB
| | {1} is loading. |
| | Exit Picture-in-Picture |
| | Picture-in-Picture |
| es.json (missing 2) | Exit Picture-in-Picture |
| | Picture-in-Picture |
| es.json (Complete) | |
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was picked up when running: npm run docs:lang It must have been missed with a bug fix.

Copy link
Member

@gkatsev gkatsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@codecov
Copy link

codecov bot commented Jul 2, 2021

Codecov Report

Merging #7300 (3fdcf8f) into main (a8a5e02) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #7300   +/-   ##
=======================================
  Coverage   79.45%   79.45%           
=======================================
  Files         115      115           
  Lines        7266     7266           
  Branches     1746     1746           
=======================================
  Hits         5773     5773           
  Misses       1493     1493           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8a5e02...3fdcf8f. Read the comment docs.

@dykwiat
Copy link
Contributor Author

dykwiat commented Jul 13, 2021

@gkatsev @bcbclifford - Anything else I need to do to get this merged?

@gkatsev
Copy link
Member

gkatsev commented Jul 13, 2021

@dykwiat nothing on your end. Since it adds a new language, we generally release that as a minor, but I'd like to do a patch release first.

@dykwiat
Copy link
Contributor Author

dykwiat commented Jul 13, 2021

Sounds good @gkatsev ! Thanks!

@gkatsev gkatsev merged commit 5c2a45b into videojs:main Jul 28, 2021
@welcome
Copy link

welcome bot commented Jul 28, 2021

Congrats on merging your first pull request! 🎉🎉🎉

edirub pushed a commit to edirub/video.js that referenced this pull request Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants