-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Romanian language and update translations doc. #7300
Conversation
💖 Thanks for opening this pull request! 💖 Things that will help get your PR across the finish line:
We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can. |
@@ -329,8 +329,7 @@ This default value is hardcoded as a default to the localize method in the SeekB | |||
| | {1} is loading. | | |||
| | Exit Picture-in-Picture | | |||
| | Picture-in-Picture | | |||
| es.json (missing 2) | Exit Picture-in-Picture | | |||
| | Picture-in-Picture | | |||
| es.json (Complete) | | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was picked up when running: npm run docs:lang
It must have been missed with a bug fix.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Codecov Report
@@ Coverage Diff @@
## main #7300 +/- ##
=======================================
Coverage 79.45% 79.45%
=======================================
Files 115 115
Lines 7266 7266
Branches 1746 1746
=======================================
Hits 5773 5773
Misses 1493 1493 Continue to review full report at Codecov.
|
@gkatsev @bcbclifford - Anything else I need to do to get this merged? |
@dykwiat nothing on your end. Since it adds a new language, we generally release that as a minor, but I'd like to do a patch release first. |
Sounds good @gkatsev ! Thanks! |
Congrats on merging your first pull request! 🎉🎉🎉 |
Description
This is to add Romanian to video js.
Specific Changes proposed
Please list the specific changes involved in this pull request.
Requirements Checklist
Tested in chrome by changing the sandbox inbox.html to use romanian: