Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add tests for the click user action #7507

Merged
merged 1 commit into from
Nov 10, 2021
Merged

test: add tests for the click user action #7507

merged 1 commit into from
Nov 10, 2021

Conversation

gkatsev
Copy link
Member

@gkatsev gkatsev commented Nov 10, 2021

f3913cd is the test for #7495.
Once that one is in, I'll rebase this PR and merge it in, these tests are copied and updated from the doubleClick userAction tests.

@codecov
Copy link

codecov bot commented Nov 10, 2021

Codecov Report

Merging #7507 (ac05a5a) into main (ca2f5a3) will increase coverage by 0.21%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #7507      +/-   ##
==========================================
+ Coverage   79.62%   79.84%   +0.21%     
==========================================
  Files         116      116              
  Lines        7309     7309              
  Branches     1764     1764              
==========================================
+ Hits         5820     5836      +16     
+ Misses       1489     1473      -16     
Impacted Files Coverage Δ
src/js/player.js 87.73% <0.00%> (+1.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca2f5a3...ac05a5a. Read the comment docs.

@gkatsev gkatsev added the needs: LGTM Needs one or more additional approvals label Nov 10, 2021
@misteroneill misteroneill removed the needs: LGTM Needs one or more additional approvals label Nov 10, 2021
@gkatsev gkatsev merged commit 8abe438 into main Nov 10, 2021
@gkatsev gkatsev deleted the click-ua-test branch November 10, 2021 19:17
edirub pushed a commit to edirub/video.js that referenced this pull request Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants