refactor: Remove workarounds for platforms without native promise support #7715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## next #7715 +/- ##
==========================================
+ Coverage 80.88% 80.93% +0.04%
==========================================
Files 116 116
Lines 7454 7442 -12
Branches 1806 1797 -9
==========================================
- Hits 6029 6023 -6
+ Misses 1425 1419 -6
Continue to review full report at Codecov.
|
|
Probably a |
gkatsev
reviewed
Apr 8, 2022
| } | ||
| function changeHandler() { | ||
| offHandler(); | ||
| resolve(); |
There was a problem hiding this comment.
Are these newly not covered by tests or were they always not covered by tests?
There was a problem hiding this comment.
They were always not covered. This PR technically increased project coverage by .05%.
alex-barstow
changed the title
gkatsev
approved these changes
Apr 11, 2022
misteroneill
approved these changes
Apr 14, 2022
misteroneill
pushed a commit
that referenced
this pull request
May 19, 2022
…7715) BREAKING CHANGE: Removes support for Promise class option and assumes native Promise is available. Will break in older browsers or devices.
misteroneill
pushed a commit
that referenced
this pull request
May 23, 2022
…7715) BREAKING CHANGE: Removes support for Promise class option and assumes native Promise is available. Will break in older browsers or devices.
24 tasks
misteroneill
pushed a commit
that referenced
this pull request
Nov 23, 2022
…7715) BREAKING CHANGE: Removes support for Promise class option and assumes native Promise is available. Will break in older browsers or devices.
misteroneill
pushed a commit
that referenced
this pull request
Nov 23, 2022
…7715) BREAKING CHANGE: Removes support for Promise class option and assumes native Promise is available. Will break in older browsers or devices.
edirub
pushed a commit
to edirub/video.js
that referenced
this pull request
Jun 8, 2023
…ideojs#7715) BREAKING CHANGE: Removes support for Promise class option and assumes native Promise is available. Will break in older browsers or devices.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove
Promiseoption and any workarounds for platforms without native promise support.Note: Merge with
BREAKING CHANGEheader