revert: Revert #7067 so we throw an error for invalid event types #7719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## next #7719 +/- ##
==========================================
- Coverage 80.88% 80.87% -0.01%
==========================================
Files 116 116
Lines 7454 7451 -3
Branches 1806 1804 -2
==========================================
- Hits 6029 6026 -3
Misses 1425 1425
Continue to review full report at Codecov.
|
misteroneill
approved these changes
Apr 11, 2022
24 tasks
edirub
pushed a commit
to edirub/video.js
that referenced
this pull request
Jun 8, 2023
…pes (videojs#7719) BREAKING CHANGE: Instead of logging an error message, invalid events will now trigger an `Error` which will terminate the call stack.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reverts #7067 which replaced throwing an error with logging an error. If we get an invalid event type we really should throw because it indicates something has gone wrong.