feature: Remove support for setting nonstandard attributes as props #7857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## next #7857 +/- ##
==========================================
+ Coverage 81.60% 81.78% +0.17%
==========================================
Files 110 111 +1
Lines 7350 7373 +23
Branches 1777 1779 +2
==========================================
+ Hits 5998 6030 +32
+ Misses 1352 1343 -9
Help us with your feedback. Take ten seconds to tell us how you rate us. |
misteroneill
requested changes
Jul 28, 2022
src/js/utils/dom.js
Outdated
| textContent(el, val); | ||
| } else if (el[propName] !== val || propName === 'tabIndex') { | ||
| el[propName] = val; | ||
| } | ||
| }); | ||
|
|
||
| Object.getOwnPropertyNames(attributes).forEach(function(attrName) { | ||
| el.setAttribute(attrName, attributes[attrName]); | ||
| Object.entries(attributes).forEach(([attrName, val]) => { |
There was a problem hiding this comment.
Unfortunately we can't use entries. Our minimum Chromium version will be 53 (because of WebOS 4.x) and it wasn't added until Chromium 54. 😢
There was a problem hiding this comment.
No problem, quick change there.
24 tasks
misteroneill
pushed a commit
that referenced
this pull request
Nov 23, 2022
…7857) * remove statement that handles attributes in props argument * clean up function * add unit test * add unit test * remove duplicate set attr * revert function cleanup
misteroneill
pushed a commit
that referenced
this pull request
Nov 23, 2022
…7857) * remove statement that handles attributes in props argument * clean up function * add unit test * add unit test * remove duplicate set attr * revert function cleanup
edirub
pushed a commit
to edirub/video.js
that referenced
this pull request
Jun 8, 2023
…ideojs#7857) * remove statement that handles attributes in props argument * clean up function * add unit test * add unit test * remove duplicate set attr * revert function cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Amend the
createElmethod on the Dom class to remove logic that allowsrole,type, andaria-*attributes to be set as part of the properties object on an element.Changes include:
createElmethod that checks for nonstandard attributes in the properties object and sets them as element attributes.tabIndexattribute assignment inSlider.creatElmethod.Specific Changes proposed
Please list the specific changes involved in this pull request.
Requirements Checklist