Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for a list of QualityLevels #7897

Merged
merged 14 commits into from
Oct 4, 2022

Conversation

gjanblaszczyk
Copy link
Member

@gjanblaszczyk gjanblaszczyk commented Aug 28, 2022

Description

The PR enables by default the functionality from videojs-contrib-quality-levels repository .
The list of QualityLevels can be accessed using qualityLevels() on the Player object. You can read more about the plugin here:
https://github.com/videojs/videojs-contrib-quality-levels.

Specific Changes proposed

Attaches the plugin to the video.js player similarly to how the http-steaming plugin was added.

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
    • Change has been verified in an actual browser (Chrome, Firefox, IE)
    • Unit Tests updated or fixed
    • Docs/guides updated
    • Example created (starter template on JSBin)
  • Reviewed by Two Core Contributors

@codecov
Copy link

codecov bot commented Aug 28, 2022

Codecov Report

Merging #7897 (c1d3fd8) into next (b5fefde) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             next    #7897      +/-   ##
==========================================
- Coverage   81.96%   81.95%   -0.01%     
==========================================
  Files         111      110       -1     
  Lines        7356     7333      -23     
  Branches     1776     1767       -9     
==========================================
- Hits         6029     6010      -19     
+ Misses       1327     1323       -4     
Impacted Files Coverage Δ
src/js/video.js 94.06% <ø> (-0.05%) ⬇️
...rc/js/control-bar/progress-control/time-tooltip.js 84.61% <0.00%> (+2.56%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@gjanblaszczyk gjanblaszczyk changed the title feat: add a new list of QualityLevels feat: add support for a list of QualityLevels Sep 1, 2022
@misteroneill misteroneill merged commit 7370e15 into videojs:next Oct 4, 2022
misteroneill pushed a commit that referenced this pull request Nov 23, 2022
This brings the videojs-contrib-quality-levels plugin into Video.js as a feature.
misteroneill pushed a commit that referenced this pull request Nov 23, 2022
This brings the videojs-contrib-quality-levels plugin into Video.js as a feature.
misteroneill pushed a commit that referenced this pull request Nov 23, 2022
This brings the videojs-contrib-quality-levels plugin into Video.js as a feature.
misteroneill pushed a commit that referenced this pull request Nov 23, 2022
This brings the videojs-contrib-quality-levels plugin into Video.js as a feature.
edirub pushed a commit to edirub/video.js that referenced this pull request Jun 8, 2023
This brings the videojs-contrib-quality-levels plugin into Video.js as a feature.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants