-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for a list of QualityLevels #7897
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## next #7897 +/- ##
==========================================
- Coverage 81.96% 81.95% -0.01%
==========================================
Files 111 110 -1
Lines 7356 7333 -23
Branches 1776 1767 -9
==========================================
- Hits 6029 6010 -19
+ Misses 1327 1323 -4
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
gkatsev
approved these changes
Aug 29, 2022
gjanblaszczyk
changed the title
feat: add a new list of QualityLevels
feat: add support for a list of QualityLevels
Sep 1, 2022
7 tasks
gkatsev
approved these changes
Oct 4, 2022
misteroneill
approved these changes
Oct 4, 2022
misteroneill
pushed a commit
that referenced
this pull request
Nov 23, 2022
This brings the videojs-contrib-quality-levels plugin into Video.js as a feature.
misteroneill
pushed a commit
that referenced
this pull request
Nov 23, 2022
This brings the videojs-contrib-quality-levels plugin into Video.js as a feature.
misteroneill
pushed a commit
that referenced
this pull request
Nov 23, 2022
This brings the videojs-contrib-quality-levels plugin into Video.js as a feature.
misteroneill
pushed a commit
that referenced
this pull request
Nov 23, 2022
This brings the videojs-contrib-quality-levels plugin into Video.js as a feature.
edirub
pushed a commit
to edirub/video.js
that referenced
this pull request
Jun 8, 2023
This brings the videojs-contrib-quality-levels plugin into Video.js as a feature.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The PR enables by default the functionality from
videojs-contrib-quality-levels
repository .The list of QualityLevels can be accessed using qualityLevels() on the Player object. You can read more about the plugin here:
https://github.com/videojs/videojs-contrib-quality-levels.
Specific Changes proposed
Attaches the plugin to the video.js player similarly to how the
http-steaming
plugin was added.Requirements Checklist