Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update jsdoc template for better usability on mobile #8048

Merged
merged 10 commits into from
Mar 22, 2023

Conversation

mister-ben
Copy link
Contributor

@mister-ben mister-ben commented Dec 16, 2022

The current jsodc template isn't very usable on mobile, and scores poorly in Lighthouse/Google Search Console in particular because of the small text. The TUI theme is unmaintained, so I've switched to https://github.com/ankitskvmdam/clean-jsdoc-theme which is a more responsive/accessible.

Removed guides as they live on videojs.com now.

To do:

  • Display version number
  • Get rid of js file listing from front page
  • Compare paths, in case any redirects needed
  • Add logo

Preview: https://deploy-preview-8048--videojs-docs.netlify.app/

"template": "node_modules/tui-jsdoc-template",
"package": "package.json",
"template": "node_modules/clean-jsdoc-theme",
"package": "",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with this theme, this keeps the output in the root of the destination dir and not at package/version/

@codecov
Copy link

codecov bot commented Dec 16, 2022

Codecov Report

Merging #8048 (3815bcb) into main (b306ce6) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #8048      +/-   ##
==========================================
+ Coverage   82.00%   82.01%   +0.01%     
==========================================
  Files         110      110              
  Lines        7339     7339              
  Branches     1770     1770              
==========================================
+ Hits         6018     6019       +1     
+ Misses       1321     1320       -1     
Impacted Files Coverage Δ
src/js/tracks/text-track.js 94.87% <0.00%> (+0.64%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@gkatsev
Copy link
Member

gkatsev commented Dec 16, 2022

I'm not a fan of the main page (specifically, the list of all files in the project), but otherwise, looks good 👍🏻

@mister-ben
Copy link
Contributor Author

Yeah, I was looking for an option to remove that big list.

Copy link
Member

@misteroneill misteroneill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, the list is a bit too "in your face" for the entry point, but overall looks fantastic!

@mister-ben
Copy link
Contributor Author

The theme author is looking into why the file list is there, it's not intentional.

@mister-ben mister-ben marked this pull request as ready for review January 6, 2023 09:23
@mister-ben
Copy link
Contributor Author

The file list is gone. I've added a script to update the jsdoc config file so it invludes the current version number in the link bakc to github, since this tempalte doesn't otherwise display the number.

@mister-ben mister-ben merged commit c1a1f9c into videojs:main Mar 22, 2023
edirub pushed a commit to edirub/video.js that referenced this pull request Jun 8, 2023
)

* docs: Update jsdoc template for better use on mobile

* add logo

* add logo css

* redirects should have trailing slash to avoid another redirect

* add and style linnks in header, remove from footer

* update theme to get rid of file list

* improve doc index text

* Add version number in Github link
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants